Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 443 update vjsf #1172

Merged
merged 4 commits into from
Jan 8, 2024
Merged

fix: 443 update vjsf #1172

merged 4 commits into from
Jan 8, 2024

Conversation

dominikhorn93
Copy link
Contributor

Description

Update vjsf to limit the input for number fields

Reference

Issues: closes #443

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@github-actions github-actions bot added digiwf-apps bug Something isn't working labels Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4ee9d2) 38.50% compared to head (70f2ff3) 38.50%.

❗ Current head 70f2ff3 differs from pull request most recent head 9c8dbf5. Consider uploading reports for the commit 9c8dbf5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1172   +/-   ##
=========================================
  Coverage     38.50%   38.50%           
  Complexity     1306     1306           
=========================================
  Files           598      598           
  Lines          8666     8666           
  Branches        423      423           
=========================================
  Hits           3337     3337           
  Misses         5191     5191           
  Partials        138      138           
Flag Coverage Δ
unittests 38.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das Update von vjsf funktioniert ja auch nicht stabil, da man auch , oder ,0 oder 0-0 eingeben könnte

@darenegade
Copy link
Member

Das Update von vjsf funktioniert ja auch nicht stabil, da man auch , oder ,0 oder 0-0 eingeben könnte

Wurde gefixed durch it-at-m/vuetify-jsonschema-form@8330e43

Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Müsste jetzt passen, was die Validierung des Inputs betrifft

@dominikhorn93 dominikhorn93 enabled auto-merge (squash) January 8, 2024 15:18
@dominikhorn93 dominikhorn93 merged commit ca7fb28 into dev Jan 8, 2024
5 checks passed
@dominikhorn93 dominikhorn93 deleted the fix/443_update_vjsf branch January 8, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gleitkomma-Input: Strings werden nicht korrekt validiert
3 participants