Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(#1115): multifile-input does not show files ins subfolders #1171

Merged
merged 8 commits into from
Jan 10, 2024

Conversation

lmoesle
Copy link
Contributor

@lmoesle lmoesle commented Jan 5, 2024

Description

  • Prozessanpassung für den Bugfix in der Formserver Integration
  • multifile-input does not show files ins subfolders
  • Bugfix im Connector (damit der Connector wieder startet)

Reference

Issues: closes #1115

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@github-actions github-actions bot added digiwf-engine bug Something isn't working labels Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d1d176f) 38.50% compared to head (fac1afb) 38.50%.
Report is 8 commits behind head on dev.

Files Patch % Lines
...en/oss/digiwf/shared/file/AbstractFileService.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1171   +/-   ##
=========================================
  Coverage     38.50%   38.50%           
- Complexity     1306     1308    +2     
=========================================
  Files           598      598           
  Lines          8666     8671    +5     
  Branches        423      424    +1     
=========================================
+ Hits           3337     3339    +2     
- Misses         5191     5194    +3     
  Partials        138      138           
Flag Coverage Δ
unittests 38.50% <46.15%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmoesle lmoesle changed the title chore: adjust formserver example process to multifile input bugfix bugfix: read files recursively from s3 storage Jan 8, 2024
@lmoesle lmoesle marked this pull request as draft January 8, 2024 17:23
@github-actions github-actions bot added the docs label Jan 10, 2024
@lmoesle lmoesle changed the title bugfix: read files recursively from s3 storage bugfix(#1115): multifile-input does not show files ins subfolders Jan 10, 2024
@lmoesle lmoesle marked this pull request as ready for review January 10, 2024 10:16
@lmoesle lmoesle merged commit 3359000 into dev Jan 10, 2024
7 checks passed
@lmoesle lmoesle deleted the bugfix/formserver-multi-file-input branch January 10, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formserver-Integration Multi-File Handling falsch
2 participants