Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: npm audit fix #1167

Merged
merged 1 commit into from
Jan 8, 2024
Merged

chore: npm audit fix #1167

merged 1 commit into from
Jan 8, 2024

Conversation

lmoesle
Copy link
Contributor

@lmoesle lmoesle commented Jan 2, 2024

Description

  • Run npm audit fix
  • Run npm run build modifies component.d.ts

Reference

Issues: closes #xxx

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2adc59) 38.50% compared to head (59a4beb) 38.50%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1167   +/-   ##
=========================================
  Coverage     38.50%   38.50%           
  Complexity     1306     1306           
=========================================
  Files           598      598           
  Lines          8666     8666           
  Branches        423      423           
=========================================
  Hits           3337     3337           
  Misses         5191     5191           
  Partials        138      138           
Flag Coverage Δ
unittests 38.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@StephanStrehlerCGI StephanStrehlerCGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gerade alles nochmal lokal bei mir ausprobiert. Taskliste und forms laufen und können auch gebaut werden kann es auch.

kann also gemerged werden

@lmoesle lmoesle merged commit d4ee9d2 into dev Jan 8, 2024
10 checks passed
@lmoesle lmoesle deleted the chore/npm-audit-fix branch January 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants