Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connector fix feign client exception handling #1137

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Dec 18, 2023

Description

Fixes feign error when parsing exception from engine.

Reference

Issues: closes #1138

@simonhir simonhir self-assigned this Dec 18, 2023
@github-actions github-actions bot added digiwf-connector bug Something isn't working labels Dec 18, 2023
Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it helps 🙈

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4896f4) 37.47% compared to head (a35422f) 37.47%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1137   +/-   ##
=========================================
  Coverage     37.47%   37.47%           
  Complexity     1254     1254           
=========================================
  Files           598      598           
  Lines          8636     8636           
  Branches        422      422           
=========================================
  Hits           3236     3236           
  Misses         5264     5264           
  Partials        136      136           
Flag Coverage Δ
unittests 37.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir simonhir merged commit f0e2230 into dev Dec 18, 2023
9 checks passed
@simonhir simonhir deleted the fix/connector-fein-dev branch December 18, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connector feign client not working
2 participants