Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(#1114): switch to camunda rest client feign #1117

Conversation

lmoesle
Copy link
Contributor

@lmoesle lmoesle commented Dec 13, 2023

Description

Short description or comments

Reference

Issues: closes #1114

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4f6bd44) 37.66% compared to head (a8688db) 37.72%.

Files Patch % Lines
...en/oss/digiwf/connector/CamundaSecurityConfig.java 0.00% 4 Missing ⚠️
...amunda/connector/incident/IncidentServiceImpl.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             release/2023-december    #1117      +/-   ##
===========================================================
+ Coverage                    37.66%   37.72%   +0.06%     
  Complexity                    1258     1258              
===========================================================
  Files                          600      600              
  Lines                         8698     8681      -17     
  Branches                       422      423       +1     
===========================================================
- Hits                          3276     3275       -1     
+ Misses                        5289     5272      -17     
- Partials                       133      134       +1     
Flag Coverage Δ
unittests 37.72% <45.45%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmoesle lmoesle changed the title refactoring(#1114): switch to camunda rest client feign hotfix(#1114): switch to camunda rest client feign Dec 14, 2023
@lmoesle lmoesle merged commit 01b17a5 into release/2023-december Dec 14, 2023
6 checks passed
@lmoesle lmoesle deleted the refactoring/switch-to-camunda-rest-client-feign-1114 branch December 14, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants