Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: send html emails in legacy features #1111

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

lmoesle
Copy link
Contributor

@lmoesle lmoesle commented Dec 11, 2023

Description

Short description or comments

Reference

Issues: closes #1109

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@github-actions github-actions bot added digiwf-engine bug Something isn't working labels Dec 11, 2023
@lmoesle lmoesle force-pushed the bugfix/send-mail-notifications-dev branch from a7fcf8a to 6d6cb76 Compare December 11, 2023 17:08
@lmoesle lmoesle enabled auto-merge (squash) December 11, 2023 17:09
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d7bce5f) 37.70% compared to head (a4ae96d) 37.69%.

Files Patch % Lines
...gacy/mailing/process/SendMailTemplateDelegate.java 0.00% 1 Missing ⚠️
...ling/process/SendMailTemplateWithLinkDelegate.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1111      +/-   ##
============================================
- Coverage     37.70%   37.69%   -0.01%     
  Complexity     1261     1261              
============================================
  Files           600      600              
  Lines          8696     8698       +2     
  Branches        422      422              
============================================
  Hits           3279     3279              
- Misses         5283     5285       +2     
  Partials        134      134              
Flag Coverage Δ
unittests 37.69% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt

@lmoesle lmoesle merged commit d82216d into dev Dec 12, 2023
5 of 7 checks passed
@lmoesle lmoesle deleted the bugfix/send-mail-notifications-dev branch December 12, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-engine digiwf-libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User email notification are sent as text based emails
2 participants