Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: send html emails in legacy features #1110

Merged

Conversation

lmoesle
Copy link
Contributor

@lmoesle lmoesle commented Dec 11, 2023

Description

Short description or comments

Reference

Issues: closes #1109

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@github-actions github-actions bot added digiwf-engine bug Something isn't working labels Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d68e6dc) 37.67% compared to head (d4c925e) 37.66%.

Files Patch % Lines
...gacy/mailing/process/SendMailTemplateDelegate.java 0.00% 1 Missing ⚠️
...ling/process/SendMailTemplateWithLinkDelegate.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             release/2023-december    #1110      +/-   ##
===========================================================
- Coverage                    37.67%   37.66%   -0.01%     
  Complexity                    1258     1258              
===========================================================
  Files                          600      600              
  Lines                         8696     8698       +2     
  Branches                       422      422              
===========================================================
  Hits                          3276     3276              
- Misses                        5287     5289       +2     
  Partials                       133      133              
Flag Coverage Δ
unittests 37.66% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir
Copy link
Member

@lmoesle glaub das in dem Bug war per Element-Template direkt auf die Integration, würde das dann nicht noch fehlen?
Und hatte es gestern auch einmal probiert, da wurden Umlaute in der Mail bzw. im speziellen beim Button mit "Task öffnen" nicht korrekt angezeigt. Das müsste ja dann auch ein anderes Problem sein oder?

@lmoesle lmoesle merged commit 8f37890 into release/2023-december Dec 12, 2023
4 of 6 checks passed
@lmoesle lmoesle deleted the bugfix/send-mail-notifications-as-html-#1109 branch December 12, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-engine digiwf-libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants