Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix entity scan and missing polyflow-kafka profile activation #1065

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

zambrovski
Copy link
Contributor

Description

  • fix entity scan
  • ⚡ missing polyflow-kafka profile activation

Details

After removal of BeanPostProcessor in polyflow-conector the default activation of polyflow-kafka spring profile was gone. Now it is included as a default to the engine profiles via application.yml in the engine service.

@github-actions github-actions bot added digiwf-task digiwf-engine bug Something isn't working labels Nov 30, 2023
@zambrovski zambrovski changed the title fix entity scan and missing polyflow-kafka profile activtion fix entity scan and missing polyflow-kafka profile activation Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (80c7253) 36.96% compared to head (6f55385) 36.95%.

Files Patch % Lines
...f/shared/configuration/JpaEngineConfiguration.java 0.00% 1 Missing ⚠️
...igiwf/task/PolyflowConnectorAutoConfiguration.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1065      +/-   ##
============================================
- Coverage     36.96%   36.95%   -0.01%     
  Complexity     1230     1230              
============================================
  Files           606      607       +1     
  Lines          8765     8767       +2     
  Branches        419      419              
============================================
  Hits           3240     3240              
- Misses         5392     5394       +2     
  Partials        133      133              
Flag Coverage Δ
unittests 36.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zambrovski
Copy link
Contributor Author

Copy link
Contributor

@lmoesle lmoesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@lmoesle lmoesle merged commit 69efd65 into dev Nov 30, 2023
7 of 9 checks passed
@lmoesle lmoesle deleted the bugfix/post_axon_4_9_and_spb_3_fixes branch November 30, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-engine digiwf-task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants