Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#768 increase okewo integration to sb3 #1062

Merged
merged 13 commits into from
Dec 11, 2023

Conversation

StephanStrehlerCGI
Copy link
Contributor

@StephanStrehlerCGI StephanStrehlerCGI commented Nov 29, 2023

Description

Short description or comments

Reference

Issues: closes #768

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8caa242) 37.67% compared to head (2dde955) 37.67%.

❗ Current head 2dde955 differs from pull request most recent head ce3966a. Consider uploading reports for the commit ce3966a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1062   +/-   ##
=========================================
  Coverage     37.67%   37.67%           
  Complexity     1261     1261           
=========================================
  Files           601      601           
  Lines          8703     8703           
  Branches        422      422           
=========================================
  Hits           3279     3279           
  Misses         5290     5290           
  Partials        134      134           
Flag Coverage Δ
unittests 37.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	digiwf-integrations/digiwf-okewo-integration/digiwf-okewo-integration-core/pom.xml
#	digiwf-integrations/digiwf-okewo-integration/pom.xml
Copy link
Contributor

@zambrovski zambrovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the requested changes.

@zambrovski zambrovski enabled auto-merge (squash) December 11, 2023 11:14
@zambrovski zambrovski merged commit 7d7d6c3 into dev Dec 11, 2023
5 checks passed
@zambrovski zambrovski deleted the feature/#768-increase-okewo-integration-to-sb3 branch December 11, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate digiwf-integrations to Spring Boot 3
2 participants