Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ADRs #1057

Merged
merged 2 commits into from
Dec 8, 2023
Merged

add ADRs #1057

merged 2 commits into from
Dec 8, 2023

Conversation

zambrovski
Copy link
Contributor

@zambrovski zambrovski commented Nov 27, 2023

Description

ADRs for usage of Clean/Hex and Package naming

Reference

Issues: fix #1054

Warum so viele Reviewer?

  • Durch das "review" hat man es dann einmal gelesen und erklärt sich damit einverstanden...

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d37c14c) 37.67% compared to head (5b3ac16) 36.78%.

❗ Current head 5b3ac16 differs from pull request most recent head 45efb57. Consider uploading reports for the commit 45efb57 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1057      +/-   ##
============================================
- Coverage     37.67%   36.78%   -0.90%     
+ Complexity     1261     1230      -31     
============================================
  Files           601      606       +5     
  Lines          8703     8809     +106     
  Branches        422      421       -1     
============================================
- Hits           3279     3240      -39     
- Misses         5290     5436     +146     
+ Partials        134      133       -1     
Flag Coverage Δ
unittests 36.78% <ø> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lmoesle lmoesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sehr gut, dass wir jetzt ADRs pflegen 💯

@simonhir simonhir self-requested a review November 30, 2023 09:11
@lmoesle
Copy link
Contributor

lmoesle commented Dec 7, 2023

@darenegade, @dominikhorn93 Könnt ihr den PR bitte noch reviewen?

Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt. Danke

@lmoesle lmoesle force-pushed the feature/1054__adr_architecture branch from 5b3ac16 to 45efb57 Compare December 8, 2023 08:29
@lmoesle lmoesle enabled auto-merge (squash) December 8, 2023 08:29
@lmoesle lmoesle merged commit 425e415 into dev Dec 8, 2023
5 checks passed
@lmoesle lmoesle deleted the feature/1054__adr_architecture branch December 8, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADR für package naming erstellen
7 participants