Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(#771): ou tree must not contain null values #1033

Merged
merged 3 commits into from
Nov 21, 2023
Merged

bugfix(#771): ou tree must not contain null values #1033

merged 3 commits into from
Nov 21, 2023

Conversation

lmoesle
Copy link
Contributor

@lmoesle lmoesle commented Nov 21, 2023 •
edited
Loading

Description

  • Refactoring der ou tree auslesen Logik, um Fehler zu vermeiden
  • Bugfix ou tree darf keine null values enthalten

Reference

Issues: closes #771

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@github-actions github-actions bot added digiwf-engine bug Something isn't working labels Nov 21, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (5195f42) 31.01% compared to head (018b5d8) 31.14%.

Files Patch % Lines
...iwf/legacy/user/external/client/LhmLdapClient.java 0.00% 14 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                     @@
##             release/2023-november    #1033      +/-   ##
===========================================================
+ Coverage                    31.01%   31.14%   +0.13%     
  Complexity                    1204     1204              
===========================================================
  Files                          632      632              
  Lines                        10170    10126      -44     
  Branches                       614      612       -2     
===========================================================
  Hits                          3154     3154              
+ Misses                        6862     6818      -44     
  Partials                       154      154
Flag Coverage Δ
unittests 31.14% <0.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmoesle
Copy link
Contributor Author

lmoesle commented Nov 21, 2023

Parallel zu diesem PR habe ich auch in EzLdap einen MR aufgemacht (https://git.muenchen.de/km23/ezLDAP/ezLDAP/-/merge_requests/70).

@lmoesle
Copy link
Contributor Author

lmoesle commented Nov 21, 2023

@darenegade, @simonhir FYI Wenn die beiden PRs (der hier und EzLdap) merged und released sind, dann sollten die ou trees wieder richtig sein. Dann heißt das SOZ aber auch wieder SOZ (und nicht mehr S-II-KJF/A).

@darenegade
Copy link
Member

Dann heißt das SOZ aber auch wieder SOZ (und nicht mehr S-II-KJF/A).

@lmoesle Die Unterabteilungen, z.B. S-II, sind aber weiterhin so drin, oder? Da aktuell die Berechtigung darauf läuft und sonst dies ein Breaking Change ist

@lmoesle
Copy link
Contributor Author

lmoesle commented Nov 21, 2023

@darenegade Ja, sonst sollte alles gleich bleiben. Ich habe's mit unterschiedlichen Usern aus unterschiedlichen Referaten getestet (die die bisher Probleme gemacht haben) und da ist sonst alles gleich geblieben

@lmoesle lmoesle merged commit 9118f84 into release/2023-november Nov 21, 2023
3 of 4 checks passed
@lmoesle lmoesle deleted the bugfix/ldap-ou-tree-contains-null-values branch November 21, 2023 14:46
simonhir added a commit that referenced this pull request Nov 29, 2023
@simonhir @github-actions
@zambrovski @lmoesle
Release 2023 November (#1007)
e318581 
* chore: bump release version (#1006)

* chore: mvn auto version bump to 1.3.1-SNAPSHOT

* v1.3.1

---------

Co-authored-by: DigiWF Github Bot <[email protected]>

* exclude old annotation support

* chore: bump release version (#1011)

* chore: mvn auto version bump to 1.3.2-SNAPSHOT

* v1.3.2

---------

Co-authored-by: DigiWF Github Bot <[email protected]>

* gateway csrf return to spring 5.8 default

* chore: bump release version (#1015)

* chore: mvn auto version bump to 1.3.3-SNAPSHOT

* v1.3.3

---------

Co-authored-by: DigiWF Github Bot <[email protected]>

* bugfix(#771): ou tree must not contain null values (#1033)

* bugfix(#771): ou tree must not contain null values

* bugfix(#771): ou tree must not contain null values

* refactor(#771): ou tree logic

---------

Co-authored-by: Lukas Mösle <[email protected]>

* chore: bump release version (#1037)

* chore: mvn auto version bump to 1.3.4-SNAPSHOT

* v1.3.4

---------

Co-authored-by: DigiWF Github Bot <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DigiWF Github Bot <[email protected]>
Co-authored-by: Simon Zambrovski <[email protected]>
Co-authored-by: Lukas Mösle <[email protected]>
Co-authored-by: Lukas Mösle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhir simonhir simonhir approved these changes

Assignees
No one assigned
Labels
bug Something isn't working digiwf-engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmoesle @darenegade @simonhir