Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task-Benachrichtigung enthält keine Zeilenumbrüche #1023

Closed
darenegade opened this issue Nov 20, 2023 · 2 comments · Fixed by #1041
Closed

Task-Benachrichtigung enthält keine Zeilenumbrüche #1023

darenegade opened this issue Nov 20, 2023 · 2 comments · Fixed by #1041
Assignees
Labels
bug Something isn't working digiwf-engine internal

Comments

@darenegade
Copy link
Member

darenegade commented Nov 20, 2023

Describe the bug

Bei einer individuelle Benachrichtigung für Aufgaben werden Zeilenumbrüche für die Mail nicht übernommen

To Reproduce

Siehe internes Ticket

Expected behavior

Zeilenumbrüche werden übernommen in der Mail

Screenshots
Siehe internes Ticket

Additional context
https://git.muenchen.de/digitalisierung/digiwf-support/-/issues/408

Nachträgliche Anmerkung: Das Ticket hat sich geändert siehe #1023 (comment)

@darenegade darenegade added bug Something isn't working digiwf-engine internal labels Nov 20, 2023
@lmoesle lmoesle self-assigned this Nov 21, 2023
@lmoesle
Copy link
Contributor

lmoesle commented Nov 21, 2023

Element Template für User Task:

{
  "name": "Basis: Usertask",
  "id": "de.muenchen.digiwf.templates.Usertask",
  "appliesTo": [
    "bpmn:UserTask"
  ],
  "properties": [
    {
      "label": "Assignee",
      "description": "Bearbeiter*in der Aufgabe",
      "type": "String",
      "binding": {
        "type": "property",
        "name": "camunda:assignee"
      }
    },
    {
      "label": "Candidate Users",
      "description": "Benutzer*in, die diesen Task bearbeiten dürfen",
      "type": "String",
      "binding": {
        "type": "property",
        "name": "camunda:candidateUsers"
      }
    },
    {
      "label": "Candidate Groups",
      "description": "Gruppen, die diesen Task bearbeiten dürfen",
      "type": "String",
      "binding": {
        "type": "property",
        "name": "camunda:candidateGroups"
      }
    },
    {
      "label": "Beschreibungstext",
      "type": "Text",
      "binding": {
        "type": "camunda:inputParameter",
        "name": "app_task_description"
      }
    },
    {
      "label": "Formular Key",
      "type": "String",
      "binding": {
        "type": "camunda:inputParameter",
        "name": "app_task_schema_key"
      }
    },
    {
      "label": "Tag",
      "type": "String",
      "binding": {
        "type": "camunda:inputParameter",
        "name": "app_task_tag"
      }
    },
    {
      "label": "Candidate Groups benachrichtigen?",
      "description": "Sendet eine E-Mail an die Candidate Groups, falls diese vorhanden sind.",
      "type": "Dropdown",
      "value": "false",
      "choices": [
        { "name": "Ja", "value": "true" },
        { "name": "Nein", "value": "false" }
      ],
      "binding": {
        "type": "camunda:inputParameter",
        "name": "app_notification_send_candidate_groups"
      }
    },
    {
      "label": "Candidate Users benachrichtigen?",
      "description": "Sendet eine E-Mail an die Candidate Users",
      "type": "Dropdown",
      "value": "false",
      "choices": [
        { "name": "Ja", "value": "true" },
        { "name": "Nein", "value": "false" }
      ],
      "binding": {
        "type": "camunda:inputParameter",
        "name": "app_notification_send_candidate_users"
      }
    },
    {
      "label": "Assignee benachrichtigen?",
      "description": "Sendet eine E-Mail an den Assginee",
      "type": "Dropdown",
      "value": "false",
      "choices": [
        { "name": "Ja", "value": "true" },
        { "name": "Nein", "value": "false" }
      ],
      "binding": {
        "type": "camunda:inputParameter",
        "name": "app_notification_send_assignee"
      }
    },
    {
      "label": "Individueller Betreff",
      "type": "String",
      "description": "Wird kein Betreff angegeben, wird der Standart Betreff verwendet",
      "binding": {
        "type": "camunda:inputParameter",
        "name": "mail_subject"
      }
    },
    {
      "label": "Individueller E-Mail Text",
      "description": "Wird kein E-Mail Text angegeben, wird der Standart E-Mail Text verwendet",
      "type": "Text",
      "binding": {
        "type": "camunda:inputParameter",
        "name": "mail_body"
      }
    },
    {
      "label": "Individueller E-Mail Gruß",
      "description": "Wird kein E-Mail Gruß angegeben, wird der Standart E-Mail Gruß verwendet",
      "type": "Text",
      "binding": {
        "type": "camunda:inputParameter",
        "name": "mail_bottom_text"
      }
    },
    {
      "label": "User für Vorgang berechtigen?",
      "description": "Gibt einem Nutzer nach Abschluss der Aufgabe Zugriff auf die Vorgangsübersicht",
      "type": "Dropdown",
      "value": "false",
      "choices": [
        { "name": "Ja", "value": "true" },
        { "name": "Nein", "value": "false" }
      ],
      "binding": {
        "type": "camunda:inputParameter",
        "name": "app_assign_user_to_processinstance"
      }
    },
    {
      "label": "S3 Pfade für Schreibrechtigungen",
      "description": "; separierte Liste an S3 Pfaden",
      "type": "String",
      "binding": {
        "type": "camunda:inputParameter",
        "name": "app_file_paths"
      }
    },
    {
      "label": "S3 Pfade für Lesebrechtigungen",
      "description": "; separierte Liste an S3 Pfaden",
      "type": "String",
      "binding": {
        "type": "camunda:inputParameter",
        "name": "app_file_paths_readonly"
      }
    }
  ],
  "entriesVisible": {
    "_all": false
  }
}

@lmoesle
Copy link
Contributor

lmoesle commented Nov 22, 2023

Aktuell kann man im Basis: Usertask Template über HTML Zeilenumbrüche im Email Body erzeugen.

Das Email Versenden Verhalten unterscheidet sich somit zwischen Taskbenachrichtigung versenden und dem Email Versand in der Email Integration. Da dies für die User verwirrend ist, wollen wir den Email Versand einheitlicher gestalten. Somit soll auch bei der Taskbenachrichtigung eine einfache Text-Email versendet und kein HTML ermöglicht werden.

Aufgabe

Der Versand von Custom Emails soll einheitlich gelöst werden (gleiches Verhalten wie in der Email Integration). WYSIWYG Die User können im Element Template Texte definieren, die als Email versendet werden. HTML Inputs werden nicht mehr unterstützt.

Akzeptanzkriterien

  • Email Versand von Custom Mails ist einheitlich gelöst
  • Task-Benachrichtigungen mit dem Element-Template Basis: Usertask werden als Text versandt (HTML wird nicht mehr unterstützt)

lmoesle added a commit that referenced this issue Nov 22, 2023
lmoesle added a commit that referenced this issue Nov 22, 2023
lmoesle added a commit that referenced this issue Nov 22, 2023
lmoesle added a commit that referenced this issue Nov 23, 2023
lmoesle added a commit that referenced this issue Nov 23, 2023
lmoesle added a commit that referenced this issue Nov 23, 2023
lmoesle added a commit that referenced this issue Nov 27, 2023
lmoesle added a commit that referenced this issue Nov 27, 2023
lmoesle added a commit that referenced this issue Nov 27, 2023
lmoesle added a commit that referenced this issue Nov 29, 2023
lmoesle added a commit that referenced this issue Nov 29, 2023
lmoesle added a commit that referenced this issue Nov 30, 2023
lmoesle added a commit that referenced this issue Nov 30, 2023
lmoesle added a commit that referenced this issue Nov 30, 2023
lmoesle added a commit that referenced this issue Nov 30, 2023
lmoesle added a commit that referenced this issue Nov 30, 2023
lmoesle added a commit that referenced this issue Nov 30, 2023
lmoesle added a commit that referenced this issue Dec 5, 2023
* feature(#1023): init digiwf-email lib with the functionality of the digiwf-email-integration-core

* feature(#1023): use digiwf-email in email-integration

* feature(#1023): clean up dependencies

* feature(#1023): init digiwf-email lib with the functionality of the digiwf-email-integration-core

* feature(#1023): use digiwf-email in engine and refactor digwif-email api

* feature(#1023): clean up after spring boot 3 migration

* test(#1023): use assertj core for unit tests

* test(#1023): use assertj core for unit tests

* test(#1023): use assertj core for unit tests

* test(#1023): use assertj core for unit tests

* tests: remove no longer needed test

* tests: tmp fixed tests

* tests: fixed tests

* feature: allow to send mails with 2 reply to addresses

* test: simplify tests with abstract base test

* test: simplify tests with abstract base test

* feature: sanitize html inputs

* feature: sanitize html inputs

* feature: sanitize html inputs

* fix: email-lib versions

* fix: email templating

* fix: send html emails

* docs: email-lib documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-engine internal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants