bugfix(#48): fix access handling in ServiceInstanceAuthService (#1082)

it-at-m · Dec 7, 2023 · d37c14c · d37c14c
1 parent afa5786
commit d37c14c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/...va/de/muenchen/oss/digiwf/process/instance/domain/service/ServiceInstanceAuthService.java b/...va/de/muenchen/oss/digiwf/process/instance/domain/service/ServiceInstanceAuthService.java
@@ -60,7 +60,7 @@ public void createAuthorization(final String processInstanceId, final String use
      * @return
      */
     public boolean hasAccess(final String instanceId, final String userId) {
-        return this.processInstanceAuthorizationRepository.findByUserIdAndProcessInstanceId(userId, instanceId).isPresent();
+        return this.processInstanceAuthorizationRepository.existsByUserIdAndProcessInstanceId(userId, instanceId);
     }
 
 }
diff --git a/...wf/process/instance/infrastructure/repository/ProcessInstanceAuthorizationRepository.java b/...wf/process/instance/infrastructure/repository/ProcessInstanceAuthorizationRepository.java
@@ -8,7 +8,6 @@
 import org.springframework.data.jpa.repository.JpaRepository;
 
 import java.util.List;
-import java.util.Optional;
 
 /**
  * Repository to perform db operation on a {@link ServiceInstanceAuthorizationEntity}
@@ -19,5 +18,5 @@ public interface ProcessInstanceAuthorizationRepository extends JpaRepository<Se
 
     List<ServiceInstanceAuthorizationEntity> findAllByUserId(String userId);
 
-    Optional<ServiceInstanceAuthorizationEntity> findByUserIdAndProcessInstanceId(String userId, String processInstanceId);
+    boolean existsByUserIdAndProcessInstanceId(String userId, String processInstanceId);
 }