Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIでgo実装にPrepareを実行するように #660

Merged
merged 6 commits into from
Sep 10, 2021
Merged

CIでgo実装にPrepareを実行するように #660

merged 6 commits into from
Sep 10, 2021

Conversation

FujishigeTemma
Copy link
Collaborator

No description provided.

nana4gonta
nana4gonta approved these changes Sep 10, 2021
View reviewed changes
Copy link
Collaborator

@nana4gonta nana4gonta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontendはOKです

@FujishigeTemma
Copy link
Collaborator Author

良さそうなのでマージします

@FujishigeTemma FujishigeTemma merged commit 45eecc5 into main Sep 10, 2021
@motoki317
Copy link
Member

19:14:54.607105 ERR: prepare: critical-error: invalid status code: 期待するHTTPステータスコード以外が返却されました. POST: /initialize, expected: 200, actual: 502

失敗してるけどベンチ自体はexit code 0だからCIは通ってしまっている

https://github.com/isucon/isucon11-final/runs/3566082735

@motoki317
Copy link
Member

-exit-status という便利なオプションがあるので使う & 502になっているのを直す

@FujishigeTemma
Copy link
Collaborator Author

ごめんね...

eagletmt added a commit that referenced this pull request Sep 11, 2021
@eagletmt
rust: Follow #660
346ed6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nana4gonta nana4gonta nana4gonta approved these changes

Assignees
No one assigned
Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FujishigeTemma @motoki317 @nana4gonta