Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

動作確認用データの追加 #634

Merged
merged 8 commits into from
Sep 9, 2021
Merged

動作確認用データの追加 #634

merged 8 commits into from
Sep 9, 2021

Conversation

kinmemodoki
Copy link
Contributor

@kinmemodoki kinmemodoki commented Sep 8, 2021 •
edited
Loading

変更点

  • webapp
    • 初期データとしていくつかのpdfを追加(/data)
    • /initializeのassignmentディレクトリを作成せずにcpする形に変更
  • bench
    • 初期データをgenerateパッケージに追加
    • validationでは追加された初期データを考慮する（courseのみ。gradeはclosedなコースが無いため省略）

@kinmemodoki kinmemodoki changed the title [WIP]動作確認用データの追加 動作確認用データの追加 Sep 8, 2021
@kinmemodoki
Copy link
Contributor Author

ULIDのPR #610 がマージされたら更新する

motoki317
motoki317 reviewed Sep 9, 2021
View reviewed changes
webapp/sql/2_init.sql Outdated Show resolved Hide resolved
TakahashiKazuya
TakahashiKazuya approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@TakahashiKazuya TakahashiKazuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います。
コースデータのTSV化は別PRで出します。

@kinmemodoki kinmemodoki merged commit d83dcfe into main Sep 9, 2021
@kinmemodoki kinmemodoki deleted the feat/init_data branch September 9, 2021 12:24
eagletmt added a commit that referenced this pull request Sep 9, 2021
@eagletmt
rust: Follow #634
91d873f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motoki317 motoki317 motoki317 left review comments

@TakahashiKazuya TakahashiKazuya TakahashiKazuya approved these changes

Assignees
No one assigned
Labels
backend benchmarker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kinmemodoki @motoki317 @TakahashiKazuya