New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

要らない誤差の比較を消す #470

Merged

FujishigeTemma merged 1 commit into main from backend/rm-unnecessary-epsilon

Aug 30, 2021

Member

motoki317 commented Aug 30, 2021 •

edited

Loading

これは消しても良い

一応理由: 前まで書いていたepsilon (machine epsilon 1つ分) での相対誤差の比較はほとんど意味が無いもの。入力値にも変な微妙な誤差が発生する可能性が無いと見て、isAllEqual判定で使っている相対誤差の比較自体を消す。


          🗑️ rm unnecessary relative error comparison

67c57c7

github-actions bot added the backend label

FujishigeTemma approved these changes

View reviewed changes

FujishigeTemma merged commit eb4d1d5 into main

FujishigeTemma deleted the backend/rm-unnecessary-epsilon branch

August 30, 2021 09:15

eagletmt mentioned this pull request

rust: Initial implementation #497

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels