New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERIM-149 Change i elements to span #161

Merged

angelamnr merged 2 commits into development from INTERIM-149

Mar 2, 2018

Member

angelamnr commented Jan 22, 2018

This pull request changes i elements to span in generated blocks with fontawesome icons.

To test:

pull down this pr on a local copy of a site
if you're on an existing site, delete the footer blocks with fontawesome icons
(re)save your theme settings to make new blocks
check to make sure that the fontawesome icons show up properly, aren't missing closing tags, etc.

angelamnr added 2 commits

January 22, 2018 11:31


          INTERIM-149 Update sitemap and site index with span

0646dc7

..instead of i


          INTERIM-149 Update social media icons to use span

2dd0a4c

Contributor

sacarney commented Feb 28, 2018

Tested, and works correctly. The icons still show up and work, and the i is now span.

angelamnr merged commit 48aa39b into development

angelamnr deleted the INTERIM-149 branch

March 2, 2018 19:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet