Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8ISUTHEME-183 Add block type classes to blocks #194

Merged
merged 1 commit into from
May 3, 2022

Conversation

sacarney
Copy link
Collaborator

To test

  1. Create a Drupal 9 site with this version of the base theme. (Very okay to make a Sites+ site)
  2. If using a Sites+ site, enable Landing Page to get Cards
  3. Structure > Blocks > Custom Block Library
  4. Create and place different kinds of blocks in theme regions.
  5. Create a custom block type and place one in a theme region.
  6. Inspect the HTML and confirm that any content blocks have a block-type_ class.
  7. NOTE: iastate8_cards block types also have their own templates and isu- block type classes. This is fine.
  8. Confirm the block-type_ class isn't showing up on, like, view blocks or system blocks.

@sacarney sacarney merged commit 97b0f24 into development May 3, 2022
@sacarney sacarney deleted the D8ISUTHEME-183 branch May 3, 2022 18:25
@sacarney sacarney mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants