Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daemonset to prow cluster to increase inotify watch limit #1515

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

Katharine
Copy link
Member

@Katharine Katharine commented Jul 19, 2019

This should reduce the incidence of failing tests. See kubernetes-sigs/kind#717.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 19, 2019
@istio-testing
Copy link
Collaborator

Hi @Katharine. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Katharine Katharine changed the title Add daemonset to increase inotify watch limit Add daemonset to prow cluster to increase inotify watch limit Jul 19, 2019
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2019
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. lgtm and removed needs-ok-to-test labels Jul 19, 2019
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: howardjohn, Katharine
To complete the pull request process, please assign cjwagner
You can assign the PR to them by writing /assign @cjwagner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid geeknoid removed the lgtm label Aug 16, 2019
@geeknoid
Copy link
Contributor

geeknoid commented Sep 4, 2019

@fejta @cjwagner @clarketm Should we merge this?

Copy link
Member

@clarketm clarketm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was already applied to the kubernetes build cluster and original istio cluster (and will need to be propagated to new istio build cluster). For the reasons mentioned in kubernetes-sigs/kind#717 it makes sense to version control and add to deployment.

@istio-testing istio-testing merged commit 2725eb9 into istio:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants