-
Notifications
You must be signed in to change notification settings - Fork 81
add test for manager. #399
base: master
Are you sure you want to change the base?
Conversation
@sdake @geeknoid I have added test for the controller and manager which needs kubebuilder binaries to get started, would you help to add kubebuilder binaries to the The test is import because it can prevent the API changes that breaks the controller. In my local env, I'm using kubebuilder v1.0.8 and everything is OK:
|
52c4ae1
to
ad7d152
Compare
/retest |
@morvencao: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @sdake @howardjohn please consider adding kubebuilder into build-tools.
@morvencao: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.