-
Notifications
You must be signed in to change notification settings - Fork 93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me.
We probably should add some comment to the docker build rules about keeping the two sets of arguments and ports in sync moving forward to avoid drift between debug and other.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 50 50
Lines 2827 2827
=======================================
Hits 2370 2370
Misses 431 431
Partials 26 26
Continue to review full report at Codecov.
|
@douglas-reid, re: keeping two sets in sync, one option is to define a bazel macro to generate images for each base type, e.g. def mixer_docker_build(name, **kwargs):
bases = [
{ "suffix": "", "image": "@docker_ubuntu//:xenial", },
{ "suffix": "_debug", "image": "@ubuntu_xenial_debug//file", }
]
for base in bases:
docker_build(
name = name+base["suffix"],
base = base["image"],
**kwargs
) mixer_docker_build(
name = "mixer",
entrypoint = [
"/usr/local/bin/mixs",
"server",
"--globalConfigFile=/etc/opt/mixer/globalconfig.yml",
"--serviceConfigFile=/etc/opt/mixer/serviceconfig.yml",
"--logtostderr",
"--v=2",
],
ports = ["9091"],
repository = "istio",
tags = ["manual"],
tars = [
":mixer_tar",
"//testdata:configs_tar",
],
) |
I like the macro approach, if others are OK with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to update with / without the macro approach. We can address that in a subsequent CL.
Updated to use the macro approach - PTAL. Also, I don't have write access to istio.io/mixer. Someone else will need to merge (or grant me access). |
Add a mixer docker image using the debug_base image (similar to manager). This is in preparation for #276 which will eventually auto-build docker images with consistent tags on merge into master via Jenkins.
This change is