Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove offending asterisk from curl output #935

Merged
merged 1 commit into from
Feb 6, 2018
Merged

remove offending asterisk from curl output #935

merged 1 commit into from
Feb 6, 2018

Conversation

vadimeisenbergibm
Copy link
Contributor

@vadimeisenbergibm vadimeisenbergibm commented Feb 6, 2018 •
edited
Loading

the asterisk does not have any meaning
it confuses jekyll, jekyll takes it as a bullet

See the format error: https://istio.io/docs/tasks/security/mutual-tls.html#testing-the-authentication-setup.

@vadimeisenbergibm
remove offending asterisk from curl output
c2ce4c8 
the asterisk does not have any meaning
it confuses jekyll, it takes it as a bullet
ldemailly
ldemailly approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh damn, thanks, my bad for not having checked the preview, sorry

it's odd - seems like the ``` isn't taking

@ldemailly ldemailly merged commit ff84954 into istio:master Feb 6, 2018
ahmetb pushed a commit to ahmetb/istio.github.io that referenced this pull request May 9, 2018
@linsun
can't get service graph to work istio#935 (istio#530)
0201b81 
* misc cleanup to setup

* can't get service graph to work istio#935

* update servicegraph picture for multi reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldemailly ldemailly ldemailly approved these changes

@geeknoid geeknoid Awaiting requested review from geeknoid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadimeisenbergibm @ldemailly