clarification on mTLS verification with curl #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from some confusion by user on slack
ldemailly
commented
Feb 2, 2018
| @@ -96,6 +96,8 @@ There are several steps: | |||
| ``` | |||
| ```bash | |||
| ... | |||
| * error fetching CN from cert:The requested data were not available. | |||
There was a problem hiding this comment.
this to show the expected error
myidpt
reviewed
Feb 2, 2018
_docs/tasks/security/mutual-tls.md
Outdated
| server identity. As a result, we use curl option '-k' to prevent the curl client from verifying service identity | ||
| in server's (i.e., productpage) certificate. | ||
| server identity. As a result, we use curl option '-k' to prevent the curl client from aborting when failing to | ||
| find and verify the service identity |
There was a problem hiding this comment.
To avoid confusion, can you change "find and verify the service identity" to "find and verify the service name"?
There was a problem hiding this comment.
k maybe server name even ?
myidpt
approved these changes
Feb 2, 2018
spikecurtis
approved these changes
Feb 2, 2018
ldemailly
commented
Feb 2, 2018
| @@ -111,11 +113,14 @@ Note that Istio uses [Kubernetes service account](https://kubernetes.io/docs/tas | |||
| as service identity, which offers stronger security than service name | |||
| (refer [here]({{home}}/docs/concepts/security/mutual-tls.html#identity) for more information). | |||
| Thus the certificates used in Istio do not have service name, which is the information that curl needs to verify | |||
| server identity. As a result, we use curl option '-k' to prevent the curl client from verifying service identity | |||
| in server's (i.e., productpage) certificate. | |||
| server identity. As a result, we use curl option '-k' to prevent the curl client from aborting when failing to | |||
There was a problem hiding this comment.
@wattli I rephrased a bit - what do you think ?
There was a problem hiding this comment.
lgtm, thanks for fixing this up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this came from some confusion by a user on slack