add a remote cluster check step to "verify the installation" multicluster setup docs

[rsalmond]

Description

Add a step to the verify the installation multicluster setup docs for executing istioctl remote clusters, and some notes about interpreting the results.

Fixes #15911

Reviewers

• Ambient
• Docs
• Installation
• Networking
• Performance and Scalability
• Extensions and Telemetry
• Security
• Test and Release
• User Experience
• Developer Infrastructure
• Localization/Translation

[istio-policy-bot]

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

• You can learn about how we write and maintain documentation, our style guidelines,
  and the available web site features by visiting Contributing to the Docs.

• In the next few minutes, an automatic preview of your change will be built with
  a full copy of the istio.io website. You can find this preview by clicking on
  the Details link next to the deploy/netlify entry in the status section of this
  page.

• We care about quality, so we've put in place a number of checks to ensure our documentation
  is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
  valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
  lint_istio.io entry in the status section. Click on the Details link to get a list of the
  problems with your PR. Fix those problems and push an update; this will automatically re-run the
  tests. Hopefully this time everything will be perfect!

• Once your changes are accepted and merged into the repository, they will initially show up
  on https://preliminary.istio.io. The changes will be published to https://istio.io
  the next time we do a major release (which typically happens every 3 months or so).
  To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
  release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[m4ver1k]

This is a generated file as per the comments on previous lines. You can skip these changes.

####################################################################################################
# WARNING: THIS IS AN AUTO-GENERATED FILE, DO NOT EDIT. PLEASE MODIFY THE ORIGINAL MARKDOWN FILE:
#          docs/setup/install/multicluster/verify/index.md
####################################################################################################

[kfaseela]

Could you please add these verification steps to the test ?

[rsalmond]

I definitely underestimated how complex the docs tests are. I think I added it to the right place, but I don't see anything obvious in the multicluster test output that suggests this test was executed.

[kfaseela]

/ok-to-test

[rsalmond]

@kfaseela @m4ver1k thanks for the feedback but I feel like I'm getting mixed messages. Should I, or should I not, make some sort of change to snips.sh? Note that at present the changes to that file are the result of running make gen.

[kfaseela]

@kfaseela @m4ver1k thanks for the feedback but I feel like I'm getting mixed messages. Should I, or should I not, make some sort of change to snips.sh? Note that at present the changes to that file are the result of running make gen.

Changes are fine. I understand it is auto generated. Those snips we should be using in the test.sh if it makes sense.

[m4ver1k]

@kfaseela @m4ver1k thanks for the feedback but I feel like I'm getting mixed messages. Should I, or should I not, make some sort of change to snips.sh? Note that at present the changes to that file are the result of running make gen.

Apologies I mistook them to be edited and not auto-generated. Please ignore my previous comment.

[kfaseela]

simply calling verify_multicluster wont be enough.. you will have to compare the output of the command to the expected output which is there in snip_verify_multicluster_1_out . Take a look at the usages of _verify_like() in other similar tests