-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added destinationrules yaml applying #15706
base: release-1.23
Are you sure you want to change the base?
Conversation
Maybe I am wrong, but shouldn't the instruction include the applying DestinationRules files? I am new at istio and just get started. My minikube cluster doesn't work without applying it. If i not apply DestinationRules, it shows errors on review zone on web page on browser.
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
The committers listed above are authorized under a signed CLA. |
Hi @Eseeldur. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@Eseeldur: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Maybe I am wrong, but shouldn't the instruction include the applying DestinationRules files? I am new at istio and just get started. My minikube cluster doesn't work without applying it. If i not apply DestinationRules, it shows errors on review zone on web page on browser.
Description
Reviewers