Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm installation steps for multi-cluster #15459

Open
wants to merge 55 commits into
base: master
Choose a base branch
from

Conversation

nshankar13
Copy link
Contributor

@nshankar13 nshankar13 commented Jul 22, 2024

Description

Adds Helm multi-cluster installation steps for all Istio multi-cluster control plane models and network topologies.

Preview link for quick reference: https://deploy-preview-15459--preliminary-istio.netlify.app/latest/docs/setup/install/multicluster/multi-primary/

Resolves: #14765

Tested against Istio 1.24.0 Helm charts.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2024
@nshankar13 nshankar13 changed the title Add helm installation steps for multi-primary Add helm installation steps for multi-cluster Jul 22, 2024
@nshankar13 nshankar13 marked this pull request as draft July 22, 2024 16:10
@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024
@nshankar13 nshankar13 marked this pull request as ready for review July 30, 2024 16:13
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 30, 2024
@dhawton
Copy link
Member

dhawton commented Jul 30, 2024

Since you're updating snips here, make sure they get added to the testing.

@nshankar13
Copy link
Contributor Author

nshankar13 commented Jul 31, 2024

@dhawton any ideas on why the lint check is complaining about spelling here?

"Install Istio as primary in cluster1 using istioctl and the IstioOperator api"

@dhawton
Copy link
Member

dhawton commented Aug 1, 2024

@dhawton any ideas on why the lint check is complaining about spelling here?

"Install Istio as primary in cluster1 using istioctl and the IstioOperator api"

Running locally (make lint) is easier to identify. It's because it's API not api.

@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 5, 2024
@nshankar13 nshankar13 requested a review from a team as a code owner August 7, 2024 20:02
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 7, 2024
@nshankar13 nshankar13 force-pushed the nshankar/helm-multicluster-install-steps branch from 2e35870 to a95cc56 Compare August 7, 2024 20:05
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 7, 2024
@nshankar13
Copy link
Contributor Author

/test doc.test.profile-default

@nshankar13 nshankar13 force-pushed the nshankar/helm-multicluster-install-steps branch from 61e5b13 to f1e6b4d Compare August 9, 2024 23:24
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 14, 2024
@nshankar13 nshankar13 force-pushed the nshankar/helm-multicluster-install-steps branch from 819b0fc to d5bf3c0 Compare August 14, 2024 21:13
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 14, 2024
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
@nshankar13 nshankar13 force-pushed the nshankar/helm-multicluster-install-steps branch from 3d92a8c to b06ee3e Compare November 8, 2024 23:04
@nshankar13
Copy link
Contributor Author

/retest-required

@nshankar13
Copy link
Contributor Author

/test doc.test.profile-default

@craigbox
Copy link
Contributor

craigbox commented Nov 9, 2024

/retest-required

@craigbox
Copy link
Contributor

craigbox commented Nov 9, 2024

/test doc.test.profile-default

multicluster log says

Error: INSTALLATION FAILED: Unable to continue with install: CustomResourceDefinition "wasmplugins.extensions.istio.io" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "istio-base"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "istio-system"

@istio-testing
Copy link
Contributor

@nshankar13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
doc.test.multicluster_istio.io b06ee3e link true /test doc.test.multicluster
doc.test.profile-default_istio.io b06ee3e link true /test doc.test.profile-default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch kind/docs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multicluster documentation uses the operator installation model
7 participants