Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

fix kind issue in CI. #139

Merged
merged 1 commit into from
May 9, 2019
Merged

fix kind issue in CI. #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ git.dep: ${GOPATH}/src/istio.io/istio ${GOPATH}/src/istio.io/tools
${GOPATH}/bin/kind:
echo ${GOPATH}
mkdir -p ${TMPDIR}
go get -u sigs.k8s.io/kind
git clone https://github.com/kubernetes-sigs/kind ${GOPATH}/src/sigs.k8s.io/kind && cd ${GOPATH}/src/sigs.k8s.io/kind && git checkout v0.2.1 && go install .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another option if docker is available and HEAD is still desired is:

Suggested change
git clone https://github.com/kubernetes-sigs/kind ${GOPATH}/src/sigs.k8s.io/kind && cd ${GOPATH}/src/sigs.k8s.io/kind && git checkout v0.2.1 && go install .
git clone https://github.com/kubernetes-sigs/kind && cd kind && make install

I do think we should instead get another kind release out and would request sticking to released versions for CI given the alpha state.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let me have a try.


${GOPATH}/bin/dep:
go get -u github.com/golang/dep/cmd/dep
Expand Down