Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project to compile and enable setting V-level #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix project to compile and enable setting V-level #6

wants to merge 4 commits into from
+7,995 −10

Commits on Dec 27, 2019

  1. Fix this project to compile 

    Enable V-level to be set.
Only log when V-level enables logging.
Copy over deps from istio/klog so unit test can run.
    @coryrc
    coryrc committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    11a3f6d View commit details
    Browse the repository at this point in the history

  2. Set Verbosity in the same way as klog 

    Makes the transition from klog to istio/klog easier.
    @coryrc
    coryrc committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    f84fe0e View commit details
    Browse the repository at this point in the history

  3. Can't interop with real glog 

    Forgot the real glog doesn't have InitFlags(). Can't interop without
forcibly altering global flags, so just make the Verbosity a public int.
    @coryrc
    coryrc committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    c97f535 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Allow setting verbosity w/out race, same as klog

    @coryrc
    coryrc committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    f2a266e View commit details
    Browse the repository at this point in the history