Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ambient virtual interface annotation for pods #3362

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bleggett
Copy link

@bleggett bleggett commented Nov 14, 2024

This is effectively an analog to https://istio.io/latest/docs/reference/config/annotations/#SidecarTrafficKubevirtInterfaces but for ambient.

Since we know it's more general than kubeVirt (it's useful for any kind of virtualized interface), it has been renamed slightly.

Relates to istio/istio#49829

This is the API side, putting it up for comment/TOC approval with a hold, impl pending.

@bleggett bleggett requested a review from a team as a code owner November 14, 2024 19:04
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2024
Signed-off-by: Benjamin Leggett <[email protected]>
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2024
Signed-off-by: Benjamin Leggett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Block automatic merging of a PR. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants