-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNSSettings for Tracer Configuration (API part) #2934
base: master
Are you sure you want to change the base?
Conversation
😊 Welcome @aatarasoff! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @aatarasoff. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
14da4c0
to
ccfc94a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This DNS issue only applies to the legacy tracing configuration. I think a more appropriate fix would be to transition to https://istio.io/latest/docs/tasks/observability/telemetry/ ?
Does this config apply to ALL tracers ? I agree with John, it's something that otel collector should handle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aatarasoff thank you for your contribution!
Could you check if it make sense to add it to the Telemetry API (per John mentioned earlier) given this is telemetry related config?
A small tip- for API change, might be good to present to our Wed's working group meeting.
I think dns refresh rate is not only to tracers, but to all DNS services. We have a We can add a respect_ttl to meshConfig, and allow agent to get both values |
Find that we have also supported dynamic bootstrap discovery, which can be used to customize the whole bootstrap config |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
A new section called
dns_settings
has been added to the Tracer Configuration. The purpose of this addition is to limit the Istio proxy's DNS queries to 10 minutes instead of the default 30 seconds when Zipkin tracing is enabled. This can be achieved by defining the below structure inMeshConfig
using this PR:Related PR: istio/istio#47049