Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing labels and annotations used for ambient #2695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add missing labels and annotations used for ambient #2695

wants to merge 1 commit into from

Conversation

GregHanson
Copy link
Member

related issue:
istio/istio#43589

@GregHanson GregHanson requested a review from a team as a code owner February 27, 2023 16:03
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 27, 2023
@istio-policy-bot
Copy link

😊 Welcome @GregHanson! This is either your first contribution to the Istio api repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing
Copy link
Collaborator

@GregHanson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
release-notes_api b681627 link false /test release-notes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson
Copy link
Member Author

@howardjohn based on istio/istio#43614 it sounds like this may be premature

@GregHanson GregHanson added the do-not-merge/hold Block automatic merging of a PR. label Feb 27, 2023
@GregHanson GregHanson mentioned this pull request Feb 27, 2023
Closed
howardjohn
howardjohn reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait for now before we get some more consensus on these

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 3, 2023
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hanxiaop hanxiaop mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/hold Block automatic merging of a PR. needs-rebase Indicates a PR needs to be rebased before being merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregHanson @istio-policy-bot @istio-testing @howardjohn