add service annotation to KubernetesResourcesSpec in operator api. #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
requested review from
dcberg,
geeknoid,
linsun,
louiscryan,
rshriram and
smawson
as code owners
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
|
/assign @ostromart |
|
@ostromart PTAL |
ostromart
approved these changes
Jan 10, 2020
|
Thanks @morvencao. We also need approval from TOC member (@smawson and @linsun are familiar with this API). |
linsun
approved these changes
Jan 10, 2020
morvencao
deleted the
br_add_service_annotation_support_for_operator_api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resubmit PR to resolve istio/istio#19959 after istio/operator#713 and #1223