Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use is-windows package for detection #88

Merged
merged 1 commit into from
May 10, 2019

Conversation

demurgos
Copy link
Contributor

This commit replaces the vendored lib/is-windows module by the is-windows package.

index.js Outdated Show resolved Hide resolved
Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor nitpick, this looks great :)

index.js Outdated Show resolved Hide resolved
Copy link
Member

@coreyfarrell coreyfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed it earlier, please remove lib/is-windows.js from package.json files list.

This commit replaces the vendored `lib/is-windows` module by the `is-windows` package.

- Closes istanbuljs#61
@demurgos
Copy link
Contributor Author

@coreyfarrell Good catch, I updated the PR.

@coreyfarrell coreyfarrell merged commit c3e6239 into istanbuljs:master May 10, 2019
@demurgos demurgos deleted the is-windows branch May 10, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use is-windows package
3 participants