build: move windows tests to travis #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: jasongin/nvs#120 |
JaKXz
commented
Jan 8, 2019
coreyfarrell
approved these changes
Jan 13, 2019
There was a problem hiding this comment.
Would be nice if we could run CI again once appveyor is disabled but the travis tests passed.
I've reproduced the test failure on under Windows 10 on my own computer. npx tap -t120 --no-cov -b ./test/build/built-062-nyc-cache-handles_collisions.js failed with node.js 11.6.0, passed with node.js 10.15.0.
coreyfarrell
force-pushed
the
windows-travis
branch
from
9332fbc
to
a296707
Compare
|
@JaKXz thank you for seeing this over the finish line. |
EwoutH
added a commit
to EwoutH/zopflipng-bin
that referenced
this pull request
Jan 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.