Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing command temp-directory #928

Merged
merged 4 commits into from
Jan 6, 2019
Merged

Commits on Oct 19, 2018

  1. Merge pull request #1 from istanbuljs/master

    Sync repo
    AndrewFinlay authored Oct 19, 2018
    Configuration menu
    Copy the full SHA
    50083f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2018

  1. Fix missing command temp-directory

    After changing tempDirectory to tempDir, with a fallback for tempDirectory, the default values set in the 'temp-dir' yargs option were being used rather than falling back to tempDirectory and then the default temp dir.
    This change removes the yargs default value for the option 'temp-dir'.
    This means the statement that assigns '_tempDirectory' in 'index.js' attempts to use temp-dir, then temp-directory, then the default value.  
    This is now under test with some new test cases that show:
      - tempDir is preferred to tempDirectory
      - tempDirectory is used if tempDir isn't set
      - that we fall back to the '.nyc_output' dir if neither tempDir or tempDirectory are set.
    Unknown committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    a02af47 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. Alternate implementation

    Maintains notice of default temp-dir in help output.
    Removed tests as I'm not confident with these right now, will take another look when I get some time.
    Unknown committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    aeccfcc View commit details
    Browse the repository at this point in the history
  2. Tidy up

    fix pointless changes
    Unknown committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    538fdc2 View commit details
    Browse the repository at this point in the history