the combination of #73 and #66 broke tests on master #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,8 @@ var fixture = require('source-map-fixtures').inline('branching') | |||
| // Coverage for the fixture is stored relative to the root directory. Here | |||
| // compute the path to the fixture file relative to the root directory. | |||
| var relpath = './' + path.relative(path.join(__dirname, '..'), fixture.file) | |||
| // the sourcemap itself remaps the path. | |||
| var mappedPath = './' + path.join(path.dirname(relpath), '../src/branching.js') | |||
There was a problem hiding this comment.
I'll see if I can add this to to the fixture object instead.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combining #73 and #66 broke tests on master:
nycin Rewrite custom require hook & source map tests #73 identified an issue withrequire.main.paths()I've instead moved to an approach that: 1. attempts requiring from the current working directory 2. falls back to requiring the full path of the additional module.CC: @Lalem001, @novemberborn