Instrumenter test and callback #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling a7bdd8a on thegecko:master into ** on istanbuljs:master**. |
bcoe
reviewed
Oct 30, 2017
| @@ -479,6 +479,23 @@ describe('the nyc cli', function () { | |||
| done() | |||
| }) | |||
| }) | |||
|
|
|||
| it('allows a sub-directory of files to be instrumented', function (done) { | |||
There was a problem hiding this comment.
awesome \o/ thank you for the test. random aside, I think these integration tests are probably the approach I should have taken all along with nyc, I think I might start retiring some of the older crufty test files that are kicking around.
|
@thegecko your changes are set to be released in
|
|
Confirmed! All changes LGTM |
This was referenced Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bcoe As #697 fixed the source-map issues I was looking to fix in #696, this PR only contains the other minor fixes included in that PR.
Specifically: