Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to new test-exclude; with suppport for node_modules #348

Merged
merged 1 commit into from
Aug 12, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Aug 12, 2016

BREAKING CHANGE: node_modules is no longer automatically excluded, and an empty array of exclude rules can be provided.

@bcoe bcoe merged commit d616ffc into master Aug 12, 2016
@bcoe bcoe deleted the test-exclude-upgrade branch August 12, 2016 05:55
@sindresorhus
Copy link
Member

node_modules is no longer automatically excluded

Why? This is very inconvenient and different from most other tools (AVA, ESLint, etc).

@bcoe
Copy link
Member Author

bcoe commented Oct 3, 2016

@sindresorhus node_modules is still excluded by the default set of rules, but if you opt to provide your own exclude rules, you must provide it yourself.

Several folks were asking to be able to instrument files in their node_modules folder, which was impossible with the old API, so I thought this was an okay compromise.

@sindresorhus
Copy link
Member

@bcoe That's what negated globs are for: ["!node_modules"] should have re-enabled node_modules.

@bcoe
Copy link
Member Author

bcoe commented Oct 3, 2016

@sindresorhus that's smart, I would definitely be comfortable with moving towards this.

@sindresorhus
Copy link
Member

Where should I open an issue? Here or test-exclude?

@bcoe
Copy link
Member Author

bcoe commented Oct 3, 2016

@sindresorhus 👍 yeah, seems reasonable; this would be another breaking change; but worthwhile you think? covering node_modules is an edge-case, and we can help those people one by one.

@sindresorhus
Copy link
Member

Yeah, I think it's worth it. Very few would cover node_modules, but many would define some excludes, which means they would need to needlessly include node_modules.

@bcoe
Copy link
Member Author

bcoe commented Oct 3, 2016

@sindresorhus sorry, only half answered your question; let's open an issue on test-exclude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants