Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extra extensions in glob for --all switch #178

Merged
merged 2 commits into from
Mar 2, 2016

Conversation

lloydcotten
Copy link
Contributor

This adds support to automatically include configured extensions when using the --all switch as per issue #174.

I simply modified an existing test to cover this scenario.

@bcoe
Copy link
Member

bcoe commented Mar 1, 2016

@lloydcotten great catch/fix 👍

my only comment, is that I think it would be worth adding an additional test. something like:

outputs an empty coverage report for all supported extensions

rather than tacking this logic onto the existing test.

@novemberborn
Copy link
Contributor

Cool. +1 on making it a separate test.

@lloydcotten
Copy link
Contributor Author

@bcoe @novemberborn I sat there and debated whether I should do that extra test or not. I suppose I should know by now that if in doubt, I should just do a new test. :-)

It's updated now.

@novemberborn
Copy link
Contributor

:shipit:

bcoe added a commit that referenced this pull request Mar 2, 2016
Include extra extensions in glob for --all switch
@bcoe bcoe merged commit b5907ad into istanbuljs:master Mar 2, 2016
@lloydcotten
Copy link
Contributor Author

@bcoe Any idea why master branch is failing after the merge? Seems to be failing on an unrelated test.

@lloydcotten
Copy link
Contributor Author

Should mention that is on Travis - passes OK locally for me.

@bcoe
Copy link
Member

bcoe commented Mar 4, 2016

@lloydcotten mind giving this branch a shot:

#180

should fix the broken build on master ... not quite sure why that cropped up when it did.

@bcoe
Copy link
Member

bcoe commented Mar 13, 2016

@lloydcotten give this a shot:

npm i nyc@next

shipped with your --all fixes. I'll release it to latest soon if everyone's testing goes well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants