Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to cover the bin/nyc.js file #138

Merged
merged 3 commits into from
Jan 18, 2016
Merged

Don't try to cover the bin/nyc.js file #138

merged 3 commits into from
Jan 18, 2016

Commits on Jan 12, 2016

  1. Don't try to cover the bin/nyc.js file 

    This makes it possible to self-test node-tap's coverage reporting and
coverage level checking when running in covered mode.  Otherwise, doing
`node {nycBin} check-coverage` results in executing the nyc executable
script as the main file (or worse, some module named `check-coverage`,
which obviously doesn't exist).
    @isaacs
    isaacs committed Jan 12, 2016
    Configuration menu
    Copy the full SHA
    52f54dc View commit details
    Browse the repository at this point in the history

  2. Split wrapping out from main nyc bin 

    This is a cleaner solution to the issue caused by spawning the nyc bin
from a test that is currently covered.

Also avoids having competing arg-parsing between yargs (better for
program arguments, user-flags, and such) and spawn-wrap, which just
splices off a set count of positional arguments from the array.
    @isaacs
    isaacs committed Jan 12, 2016
    Configuration menu
    Copy the full SHA
    fc170bb View commit details
    Browse the repository at this point in the history

  3. only run report/check-coverage based on argv._[0] 

    Checking for 'report' anywhere in the command means that something like

    nyc my-thing which-is-not-nyc report

would end up running nyc's reporter instead of my thing.
    @isaacs
    isaacs committed Jan 12, 2016
    Configuration menu
    Copy the full SHA
    64f7068 View commit details
    Browse the repository at this point in the history