Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --build-process-tree feature #1028

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

isaacs
Copy link
Collaborator

@isaacs isaacs commented Mar 14, 2019

This allows a user to build the processinfo temp files, without actually
dumping the process tree to stdout.

The goal is to use this in node-tap to see which processes covered which
files, so we know which tests to re-run on changes to the source files.

@coreyfarrell
Copy link
Member

@isaacs this produces a parse error in test/nyc-integration.js. Would you mind moving the describe('--build-process-tree', function () { out of the describe('--show-process-tree', function () {, then add the closing '}) after your new test (currently you're not closing the added describe function).

@isaacs
Copy link
Collaborator Author

isaacs commented Mar 14, 2019

@coreyfarrell Oh, oops, some rebase scar tissue got in there, how embarrassing. Fixed and force-pushed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 96.304% when pulling efcd6cd on isaacs:build-process-tree into 364eb33 on istanbuljs:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 96.304% when pulling efcd6cd on isaacs:build-process-tree into 364eb33 on istanbuljs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 96.304% when pulling efcd6cd on isaacs:build-process-tree into 364eb33 on istanbuljs:master.

@coveralls
Copy link

coveralls commented Mar 14, 2019

Coverage Status

Coverage increased (+0.007%) to 96.304% when pulling 2edc77b on isaacs:build-process-tree into 364eb33 on istanbuljs:master.

This allows a user to build the processinfo temp files, without actually
dumping the process tree to stdout.

The goal is to use this in node-tap to see which processes covered which
files, so we know which tests to re-run on changes to the source files.
index.js Show resolved Hide resolved
@JaKXz
Copy link
Member

JaKXz commented Mar 17, 2019

@coreyfarrell :shipit:

Thanks @isaacs I was just curious!

@coreyfarrell coreyfarrell merged commit 64571d3 into istanbuljs:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants