Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename plugins option to parser-plugins. #986

Closed
coreyfarrell opened this issue Feb 7, 2019 · 0 comments
Closed

Rename plugins option to parser-plugins. #986

coreyfarrell opened this issue Feb 7, 2019 · 0 comments

Comments

@coreyfarrell
Copy link
Member

At #947 (comment) @novemberborn pointed out that the plugins option is easily confused with normal babel plugins where nyc expects a list of babel parser plugins. This issue is opened so I don't forget that we should rename this option.

coreyfarrell added a commit to coreyfarrell/nyc that referenced this issue Mar 17, 2019
The original option name created confusion about what was expected.
This helps identify that babel parser plugins are expected, not babel
transform plugins.

BREAKING CHANGE: The `plugins` option has been renamed to
`parser-plugins`.

Fixes istanbuljs#986
coreyfarrell added a commit that referenced this issue Mar 18, 2019
The original option name created confusion about what was expected.
This helps identify that babel parser plugins are expected, not babel
transform plugins.

BREAKING CHANGE: The `plugins` option has been renamed to
`parser-plugins`.

Fixes #986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant