Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nyc-test needs tap --coverage #79

Closed
novemberborn opened this issue Dec 7, 2015 · 1 comment
Closed

nyc-test needs tap --coverage #79

novemberborn opened this issue Dec 7, 2015 · 1 comment

Comments

@novemberborn
Copy link
Contributor

$(npm bin)/tap test/nyc-test.js fails, where $(npm bin)/tap --coverage test/nyc-test.js succeeds. This seems wrong, tap comes bundled with nyc for its own coverage reports but that shouldn't impact the tests.
This was referenced Dec 7, 2015
Closed
Closed
Closed
@jamestalmage jamestalmage mentioned this issue Dec 9, 2015
Merged
@jamestalmage
Copy link
Member

closed via #89

jamestalmage added a commit that referenced this issue Dec 14, 2015
@jamestalmage
Merge pull request #90 from jamestalmage/recast-forking-with-capture-…
958e96c 
…require

Use capture-require module.

Closes #79 
Closes #70
Krinkle added a commit to Krinkle/nyc that referenced this issue Jan 3, 2019
@Krinkle
feat: avoid hardcoded HOME for spawn-wrap working dir
b4f39c0 
By default, spawn-wrap writes temporary files to HOME.
It used to be /tmp, but it changed that to HOME to support
environments that have 'noexec' flags set on their tmpfs mount.
Ref istanbuljs/spawn-wrap#3.

The problem with this is that nyc now no longer works in environments
without a (writable) home directory (e.g. the 'nobody' user on
Linux).

While it is fine to fallback to HOME, it should write elsewhere
if that is unavailable, and ideally in a way that doesn't require
every sysadmin or end-user to hardcode some environmnet variable
in their package.json specifically for nyc or spawn-wrap.

A common way to communicate this intent is with the XDG_CACHE_HOME
environment variable.

Fixes istanbuljs#79.
@Krinkle Krinkle mentioned this issue Jan 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@novemberborn @jamestalmage