Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execArgv not being interpreted correctly #337

Closed
bengl opened this issue Aug 1, 2016 · 2 comments
Closed

execArgv not being interpreted correctly #337

bengl opened this issue Aug 1, 2016 · 2 comments
Labels

Comments

@bengl
Copy link

bengl commented Aug 1, 2016

It appears as though when tap passes process.execArgv params into nyc, they aren't being used correctly when spawning.

For example, with a fresh clone of https://github.com/isaacs/node-glob, I ran:

$ node --expose-gc node_modules/.bin/tap test/*.js --cov

On node 6.3.1, this produces the following error:

Error: spawn --expose-gc ENOENT
    at exports._errnoException (util.js:1012:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:182:32)
    at onErrorNT (internal/child_process.js:348:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
    at Module.runMain (module.js:577:11)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3

Tap sends process.execArgv to nyc via command-line args here.

@bcoe
Copy link
Member

bcoe commented Aug 1, 2016

@bengl what version of nyc are you bumping into this issue on?

@bcoe bcoe added the bug label Aug 1, 2016
@bengl
Copy link
Author

bengl commented Aug 1, 2016

@bcoe [email protected] and [email protected]

EDIT: I just tested and the same behaviour is present with [email protected] ([email protected]).

addaleax added a commit to addaleax/nyc that referenced this issue Aug 13, 2016
Assume that commands starting with `-`, e.g. `--expose-gc script.js`,
implicitly are Node.js commands.

Fixes: istanbuljs#337
@bcoe bcoe closed this as completed in #350 Aug 14, 2016
bcoe pushed a commit that referenced this issue Aug 14, 2016
…#350)

Assume that commands starting with `-`, e.g. `--expose-gc script.js`,
implicitly are Node.js commands.

Fixes: #337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants