-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse modeling analytic continuation of self energy #135
Conversation
Thank you for the suggestion. My current code only supports self-energies that are diagonal in orbital and spin indices. However, I would like to finish the current project and move on to something else. I could integrate your code during the next semester break (Q1 2024). Also, what is your motivation to write your own ADMM solver? There are many industrial-grade solvers for this type of problem. With the configuration I am using, the solver usually runs for only a couple of seconds on a single core. I have yet to add some tests to this PR. Most likely I will be done tomorrow. |
I believe we're complete now. Please have a look. |
Thank you! Yes, let us first merge your code. @k-yoshimi
|
That one failing test was unstable. I improved it. Please try again. |
I don't understand this test failure. I think we need to debug locally with the exact container that runs the tests. |
I simplified the test and removed explicit testing of U and VT matrices. |
@danielguterding
I think there are phase degrees of freedom in U and VT and so different system or library versions may cause the discrepancy in U and VT. I think your simplification where only S is checked is a good modification. |
Can I help with that somehow? I have run quite a few test cases on my side, but didn't find the place where end-to-end tests live in DCore. |
Once @yomichi approves, it will be ready to merge the PR. |
I'm sorry for the late reply, but I did run the code. I think the results are fine. |
@yomichi |
Thank you for this suggestion. I added reasonable default values for all non-physical parameters. |
I used U=4 Hubbard model on the square lattice with
|
Are there any questions that are still open? |
No, ready to merge! (Sorry, we were stuck in a conference). Thank you for your contributions! |
@danielguterding |
dcore_pade.py
todcore_anacont_pade.py
.cvxpy
.anacont_spm.py
.dcore_anacont_spm_interactive.py
) and non-interactive (dcore_anacont_spm.py
) analytic continuation via sparse modeling.Open points: