Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ireland Missing Munster Province and it's related Counties #2529

Closed
spirescreative opened this issue Jun 25, 2024 · 5 comments
Closed

Ireland Missing Munster Province and it's related Counties #2529

spirescreative opened this issue Jun 25, 2024 · 5 comments
Labels
Milestone

Comments

@spirescreative
Copy link

When setting up the Store Configuration for Ireland, the "State" listing is missing the entirety of Munster Province, which includes counties such as Cork, Kerry and Limerick.

Is it possible to modify the Isotope Store Configuration dropdowns manually to include the missing Province and Counties?

@aschempp
Copy link
Member

aschempp commented Jul 8, 2024

Yes you can modify it manually. The data is located in system/modules/isotope/languages/en/subdivisions.php. You can create your own /contao/languages/en/subdivisions.php in your project and add the necessary options.

However, I would also be interested if these provinces have been added recently? Because the data is based on Wikipedia/ISO standards, so I wonder why these are missing there?

@fritzmg
Copy link
Contributor

fritzmg commented Jul 8, 2024

It's not missing:

$GLOBALS['TL_LANG']['DIV']['ie']['IE-M'][''] = 'Munster (An Mhumhain)';

@spirescreative
Copy link
Author

None of the counties in Munster Province are listed which is likely why the the Province doesn't show in the store config. The counties would need to be added under Munster, is my thinking.

@spirescreative
Copy link
Author

Yes you can modify it manually. The data is located in system/modules/isotope/languages/en/subdivisions.php. You can create your own /contao/languages/en/subdivisions.php in your project and add the necessary options.

Thank you for locating the data! I wasn't looking under languages for post locations. This should help and I believe that if I manually add the counties for Munster Province the same as the other counties are listed, it should populate.

Looks like the counties of Munster are missing, not the Province itself as @fritzmg pointed out.
https://en.wikipedia.org/wiki/Provinces_of_Ireland
https://en.wikipedia.org/wiki/Munster

@aschempp
Copy link
Member

aschempp commented Jul 8, 2024

Thanks for the explanation! I have updated the data in 967a687 from https://en.wikipedia.org/wiki/ISO_3166-2:IE

@aschempp aschempp closed this as completed Jul 8, 2024
@aschempp aschempp added the bug label Jul 8, 2024
@aschempp aschempp added this to the 2.9.0 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants