Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupon code label not pulling into template #2443

Closed
rburch opened this issue Apr 5, 2023 · 1 comment
Closed

Coupon code label not pulling into template #2443

rburch opened this issue Apr 5, 2023 · 1 comment
Labels
Milestone

Comments

@rburch
Copy link

rburch commented Apr 5, 2023

I've been doing an Accessibility test on a site and noticed that the Label for the coupon form is showing an empty label.

templates/iso_coupons.html5

<div class="coupon<?php echo $this->mclass ? ' ' . $this->mclass : ''; ?>">
<h2><?= $this->headline ?></h2>
<?php if ($this->message != ''): ?>
<p class="<?= $this->mclass ?>"><?= $this->message ?></p>
<?php endif; ?>

<form action="<?= $this->action ?>" method="get">
<div class="formbody">
<label for="ctrl_coupon_<?= $this->id ?>"><?= $this->label ?></label>
<input type="text" name="coupon_<?= $this->id ?>" id="ctrl_coupon_<?= $this->id ?>" class="text"> <input class="submit" type="submit" value="<?= $this->sLabel ?>">
</div>
</form>
</div>

seems like <?= $this->label ?> it's not pulling anything in.

@aschempp aschempp added the bug label Apr 12, 2023
@aschempp aschempp added this to the 2.9.0 milestone Apr 12, 2023
@aschempp aschempp modified the milestones: 2.9.0, 2.8.16 Jul 31, 2023
@aschempp
Copy link
Member

Fixed in e29fd81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants