Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK v2 support #63

Merged
merged 1 commit into from
Mar 4, 2022
Merged

CDK v2 support #63

merged 1 commit into from
Mar 4, 2022

Conversation

plumdog
Copy link
Contributor

@plumdog plumdog commented Mar 4, 2022

  • Split out the non-CDK parts to be shared
  • Duplicate the CDK parts and update the imports and apply changes for CDK v2, one in cdkv1.ts, other in cdkv2.ts
  • Duplicate the tests
  • Continue to export the CDK v1 from index.ts to maintain backwards compatibility

@plumdog plumdog force-pushed the cdkv2-support branch 3 times, most recently from cfb1ddc to 1701478 Compare March 4, 2022 20:52
@plumdog plumdog merged commit 0764f18 into master Mar 4, 2022
@plumdog plumdog deleted the cdkv2-support branch March 4, 2022 21:26
@plumdog plumdog mentioned this pull request Mar 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@plumdog