Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript-eslint dependencies and apply fixes to fix CI #33

Merged
merged 1 commit into from
Nov 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"eslint-plugin-prettier": "3.1.2",
"prettier": "1.19.1",
"@types/jest": "~24.0.22",
"@typescript-eslint/eslint-plugin": "2.16.0",
"@typescript-eslint/parser": "2.16.0"
"@typescript-eslint/eslint-plugin": "4.8.2",
"@typescript-eslint/parser": "4.8.2"
}
}
2 changes: 1 addition & 1 deletion provider/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ interface DeleteEvent extends BaseEvent {

interface Response {
PhysicalResourceId: string;
Data: {};
Data: Record<string, unknown>;
}

type Event = CreateEvent | UpdateEvent | DeleteEvent;
Expand Down
4 changes: 2 additions & 2 deletions provider/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
},
"devDependencies": {
"@types/jest": "~24.0.22",
"@typescript-eslint/eslint-plugin": "2.16.0",
"@typescript-eslint/parser": "2.16.0",
"@typescript-eslint/eslint-plugin": "4.8.2",
"@typescript-eslint/parser": "4.8.2",
"aws-sdk": ">=2",
"eslint": "6.8.0",
"eslint-config-prettier": "6.9.0",
Expand Down
6 changes: 3 additions & 3 deletions provider/tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ beforeEach(() => {
}),
}));
mockSecretsManagerPutSecretValue.mockImplementation(() => ({
promise: (): Promise<object> => Promise.resolve({}),
promise: (): Promise<Record<string, unknown>> => Promise.resolve({}),
}));
});

Expand Down Expand Up @@ -64,7 +64,7 @@ const setMockSpawn = (props: SetMockSpawnProps): MockChildProcess => {
const { stdoutData = null, stderrData = null, code = 0 } = props;
const emitter = new MockChildProcess();
// eslint-disable-next-line @typescript-eslint/no-unused-vars
(childProcess.spawn as jest.Mock).mockImplementationOnce((file: string, args: Array<string>, options: object) => {
(childProcess.spawn as jest.Mock).mockImplementationOnce((file: string, args: Array<string>, options: Record<string, unknown>) => {
if (stdoutData) {
setTimeout(() => {
emitter.stdout.emit('data', new TextEncoder().encode(stdoutData));
Expand Down Expand Up @@ -94,7 +94,7 @@ describe('onCreate', () => {
}));
const mockProc = setMockSpawn({ stdoutData: JSON.stringify({ a: 'abc' }) });
mockSecretsManagerPutSecretValue.mockImplementation(() => ({
promise: (): Promise<object> => Promise.resolve({}),
promise: (): Promise<Record<string, unknown>> => Promise.resolve({}),
}));

expect(
Expand Down