Update typescript-eslint dependencies and apply fixes to fix CI (#33)

isotoma · Nov 26, 2020 · b2900c8 · b2900c8
1 parent 525360c
commit b2900c8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -61,7 +61,7 @@
         "eslint-plugin-prettier": "3.1.2",
         "prettier": "1.19.1",
         "@types/jest": "~24.0.22",
-        "@typescript-eslint/eslint-plugin": "2.16.0",
-        "@typescript-eslint/parser": "2.16.0"
+        "@typescript-eslint/eslint-plugin": "4.8.2",
+        "@typescript-eslint/parser": "4.8.2"
     }
 }
diff --git a/provider/index.ts b/provider/index.ts
@@ -56,7 +56,7 @@ interface DeleteEvent extends BaseEvent {
 
 interface Response {
     PhysicalResourceId: string;
-    Data: {};
+    Data: Record<string, unknown>;
 }
 
 type Event = CreateEvent | UpdateEvent | DeleteEvent;

diff --git a/provider/package.json b/provider/package.json
@@ -21,8 +21,8 @@
     },
     "devDependencies": {
         "@types/jest": "~24.0.22",
-        "@typescript-eslint/eslint-plugin": "2.16.0",
-        "@typescript-eslint/parser": "2.16.0",
+        "@typescript-eslint/eslint-plugin": "4.8.2",
+        "@typescript-eslint/parser": "4.8.2",
         "aws-sdk": ">=2",
         "eslint": "6.8.0",
         "eslint-config-prettier": "6.9.0",

diff --git a/provider/tests/index.test.ts b/provider/tests/index.test.ts
@@ -33,7 +33,7 @@ beforeEach(() => {
             }),
     }));
     mockSecretsManagerPutSecretValue.mockImplementation(() => ({
-        promise: (): Promise<object> => Promise.resolve({}),
+        promise: (): Promise<Record<string, unknown>> => Promise.resolve({}),
     }));
 });
 
@@ -64,7 +64,7 @@ const setMockSpawn = (props: SetMockSpawnProps): MockChildProcess => {
     const { stdoutData = null, stderrData = null, code = 0 } = props;
     const emitter = new MockChildProcess();
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    (childProcess.spawn as jest.Mock).mockImplementationOnce((file: string, args: Array<string>, options: object) => {
+    (childProcess.spawn as jest.Mock).mockImplementationOnce((file: string, args: Array<string>, options: Record<string, unknown>) => {
         if (stdoutData) {
             setTimeout(() => {
                 emitter.stdout.emit('data', new TextEncoder().encode(stdoutData));
@@ -94,7 +94,7 @@ describe('onCreate', () => {
         }));
         const mockProc = setMockSpawn({ stdoutData: JSON.stringify({ a: 'abc' }) });
         mockSecretsManagerPutSecretValue.mockImplementation(() => ({
-            promise: (): Promise<object> => Promise.resolve({}),
+            promise: (): Promise<Record<string, unknown>> => Promise.resolve({}),
         }));
 
         expect(